[Battlemesh] BSS load element patch

Marek Lindner mareklindner at neomailbox.ch
Mon Aug 3 19:16:47 UTC 2015


On Monday, August 03, 2015 21:07:29 Arthur LENA wrote:
> +@@ -1503,6 +1504,8 @@ static int ath9k_sta_add(struct ieee8021
> +               an->key_idx[0] = key;
> +       }
> +
> ++      avp->n_assoc_stations++;
> ++
> +       return 0;
> + }
> +
> +@@ -1527,9 +1530,11 @@ static int ath9k_sta_remove(struct ieee8
> +                           struct ieee80211_sta *sta)
> + {
> +       struct ath_softc *sc = hw->priv;
> ++      struct ath_vif *avp = (void *)vif->drv_priv;
> +
> +       ath9k_del_ps_key(sc, vif, sta);
> +       ath_node_detach(sc, sta);
> ++      avp->n_assoc_stations--;
> +
> +       return 0;
> + }

Are you sure that is thread-safe ? After quickly scrolling over these 
functions I can't find any locking. You better use atomic_t instead of u16 
here.

Cheers,
Marek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://ml.ninux.org/pipermail/battlemesh/attachments/20150804/785b4af3/attachment.pgp>


More information about the Battlemesh mailing list